Skip to content

adding pokemon from champions#1491

Merged
Naramsim merged 2 commits intoPokeAPI:masterfrom
digitalghost-dev:master
Apr 18, 2026
Merged

adding pokemon from champions#1491
Naramsim merged 2 commits intoPokeAPI:masterfrom
digitalghost-dev:master

Conversation

@digitalghost-dev
Copy link
Copy Markdown
Contributor

@digitalghost-dev digitalghost-dev commented Apr 17, 2026

Change description

I've added Pokémon from Champions to the respective files outlined in issue #1484.

For the pokedex_number number, I just added the Pokémon's national Pokédex number as outlined in the Serebii Pokédex. Not sure if this was correct choice, but let me know.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@digitalghost-dev digitalghost-dev mentioned this pull request Apr 17, 2026
Closed
jemarq04
jemarq04 suggested changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jemarq04 jemarq04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the national dex numbers for these is reasonable since there's not a strict in-game pokedex. Other than the typo, this looks good!

Comment thread data/v2/csv/pokemon_dex_numbers.csv Outdated
@digitalghost-dev @jemarq04
fixing typo
43a4640 
Co-authored-by: Justin Marquez <37006684+jemarq04@users.noreply.github.com>
@Naramsim Naramsim merged commit 42ae15b into PokeAPI:master Apr 18, 2026
12 of 13 checks passed
@pokeapi-machine-user
Copy link
Copy Markdown

pokeapi-machine-user commented Apr 18, 2026

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Apr 18, 2026
@pokeapi-machine-user
[Updater Bot] Regenerate data from PokeAPI/pokeapi#1491
75b20de
@pokeapi-machine-user pokeapi-machine-user mentioned this pull request Apr 18, 2026
Merged
@pokeapi-machine-user
Copy link
Copy Markdown

pokeapi-machine-user commented Apr 18, 2026

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Apr 18, 2026
@pokeapi-machine-user
[Updater Bot] Regenerate data from PokeAPI/pokeapi#1491 (#359)
5d5a1ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jemarq04 jemarq04 jemarq04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@digitalghost-dev @pokeapi-machine-user @jemarq04 @Naramsim